lifecycle: Mention runtime.json #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wking
force-pushed
the
lifecycle-runtime.json
branch
from
1f7d5a0 to
42c2cde
Compare
wking
changed the title
Contributor
|
LGTM |
Contributor
|
this is fine, needs rebase, we should discuss removal of runtime.json though. |
wking
force-pushed
the
lifecycle-runtime.json
branch
from
42c2cde to
0a55d5c
Compare
As discussed earlier [1,2]. I'm in favor of rolling it back into config.json [3], but we aren't there yet [4]. [1]: opencontainers#231 (comment) [2]: https://github.com/opencontainers/specs/pull/231/files#r46735828 [3]: https://groups.google.com/a/opencontainers.org/forum/#!topic/dev/0QbyJDM9fWY Subject: Single, unified config file (i.e. rolling back specs#88) Date: Wed, 4 Nov 2015 09:53:20 -0800 Message-ID: <[email protected]> [4]: https://github.com/opencontainers/specs/blob/4a63e81a807edec3d67ed2b6bd99a6c2b288676f/bundle.md#container-format Signed-off-by: W. Trevor King <[email protected]>
Contributor
Author
|
On Wed, Dec 16, 2015 at 08:50:04AM -0800, Brandon Philips wrote:
Rebased around #269 with 42c2cde → 0a55d5c.
+1. My take on that is here 1, and I'm happy to go over any |
Member
|
LGtm |
crosbymichael
added a commit
that referenced
this pull request
Dec 17, 2015
lifecycle: Mention runtime.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #231. I'm in favor of rolling it back into
config.json, but we aren't there yet. I also addedbackticks around the filenames for consistency with bundle.md.
This seemed uncontroversial enough to go straight to a PR (and not via
a mailing list thread), but I'm happy to spin up a mailing list thread
around it if anyone thinks I'm overlooking a contentious issue.